third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h - Issue 2862963003: Replace ASSERT with DCHECK in modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)

Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp ('k') | third_party/WebKit/Source/modules/canvas2d/CanvasStyle.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

diff --git a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

index 7d9d7c5b385e570c9f5ff03a7ec5f3157f071cac..6963be68297a6f917a4d87dfd8ff4aba930b4da3 100644

--- a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

+++ b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

@@ -476,7 +476,7 @@ void BaseRenderingContext2D::CompositedDraw(

c->setMatrix(ctm);

draw_func(c, &foreground_flags);

} else {

- ASSERT(IsFullCanvasCompositeMode(GetState().GlobalComposite()));

+ DCHECK(IsFullCanvasCompositeMode(GetState().GlobalComposite()));

c->saveLayer(nullptr, &composite_flags);

shadow_flags.setBlendMode(SkBlendMode::kSrcOver);

c->setMatrix(ctm);