third_party/WebKit/Source/modules/audio_output_devices/SetSinkIdCallbacks.cpp - Issue 2862963003: Replace ASSERT with DCHECK in modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/audio_output_devices/SetSinkIdCallbacks.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)

Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/ModulesInitializer.cpp ('k') | third_party/WebKit/Source/modules/cachestorage/Cache.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/audio_output_devices/SetSinkIdCallbacks.cpp

diff --git a/third_party/WebKit/Source/modules/audio_output_devices/SetSinkIdCallbacks.cpp b/third_party/WebKit/Source/modules/audio_output_devices/SetSinkIdCallbacks.cpp

index 96cdd969347462fc242435057bcc34ec1a876ac5..72ecc346f40fae8727903bc48fdedfc18980b24f 100644

--- a/third_party/WebKit/Source/modules/audio_output_devices/SetSinkIdCallbacks.cpp

+++ b/third_party/WebKit/Source/modules/audio_output_devices/SetSinkIdCallbacks.cpp

@@ -37,7 +37,7 @@ SetSinkIdCallbacks::SetSinkIdCallbacks(ScriptPromiseResolver* resolver,

HTMLMediaElement& element,

const String& sink_id)

: resolver_(resolver), element_(element), sink_id_(sink_id) {

- ASSERT(resolver_);

+ DCHECK(resolver_);

}

SetSinkIdCallbacks::~SetSinkIdCallbacks() {}