third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp - Issue 2862963003: Replace ASSERT with DCHECK in modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)

Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/netinfo/WorkerNavigatorNetworkInformation.cpp ('k') | third_party/WebKit/Source/modules/presentation/Presentation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp

diff --git a/third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp b/third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp

index 745a0efe6df96fd6c3d3f19c5114532b932d18af..4a7503c08f0ef9bdf6ed7b36b225fb88172946ae 100644

--- a/third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp

+++ b/third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp

@@ -110,7 +110,7 @@ static bool IframeIsAbovePlugin(

if (ro == ro2)

return true;

}

- ASSERT(false); // We should have seen ro1 and ro2 by now.

+ NOTREACHED(); // We should have seen ro1 and ro2 by now.

return false;

}

@@ -158,7 +158,7 @@ void GetPluginOcclusions(Element* element,

const IntRect& frame_rect,

Vector<IntRect>& occlusions) {

LayoutObject* plugin_node = element->GetLayoutObject();

- ASSERT(plugin_node);

+ DCHECK(plugin_node);

if (!plugin_node->Style())

return;

Vector<const LayoutObject*> plugin_zstack;