third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp - Issue 2862963003: Replace ASSERT with DCHECK in modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)

Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp

diff --git a/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp b/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp

index edc6154f60d57c525024cfdd106f8f3390fa90cd..d022667098d7ea6fb89a7e1c1b761b66cf1c9539 100644

--- a/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp

+++ b/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp

@@ -309,7 +309,7 @@ ScriptPromise CacheStorage::match(ScriptState* script_state,

const RequestInfo& request,

const CacheQueryOptions& options,

ExceptionState& exception_state) {

- ASSERT(!request.isNull());

+ DCHECK(!request.isNull());

if (!CommonChecks(script_state, exception_state))

return ScriptPromise();