Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: third_party/WebKit/Source/modules/webgl/WebGLActiveInfo.h

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)
Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2009 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 30 matching lines...) Expand all
41 } 41 }
42 String name() const { return name_; } 42 String name() const { return name_; }
43 GLenum type() const { return type_; } 43 GLenum type() const { return type_; }
44 GLint size() const { return size_; } 44 GLint size() const { return size_; }
45 45
46 DEFINE_INLINE_TRACE() {} 46 DEFINE_INLINE_TRACE() {}
47 47
48 private: 48 private:
49 WebGLActiveInfo(const String& name, GLenum type, GLint size) 49 WebGLActiveInfo(const String& name, GLenum type, GLint size)
50 : name_(name), type_(type), size_(size) { 50 : name_(name), type_(type), size_(size) {
51 ASSERT(name.length()); 51 DCHECK(name.length());
52 ASSERT(type); 52 DCHECK(type);
53 ASSERT(size); 53 DCHECK(size);
54 } 54 }
55 String name_; 55 String name_;
56 GLenum type_; 56 GLenum type_;
57 GLint size_; 57 GLint size_;
58 }; 58 };
59 59
60 } // namespace blink 60 } // namespace blink
61 61
62 #endif // WebGLActiveInfo_h 62 #endif // WebGLActiveInfo_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698