Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: third_party/WebKit/Source/modules/cachestorage/Cache.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)
Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/cachestorage/Cache.cpp
diff --git a/third_party/WebKit/Source/modules/cachestorage/Cache.cpp b/third_party/WebKit/Source/modules/cachestorage/Cache.cpp
index 0825b5dda6c62de0f8894de5363c024a8d0bbadb..f02785cab831ec7522dd697a4116815f57ec0bcc 100644
--- a/third_party/WebKit/Source/modules/cachestorage/Cache.cpp
+++ b/third_party/WebKit/Source/modules/cachestorage/Cache.cpp
@@ -388,7 +388,7 @@ ScriptPromise Cache::match(ScriptState* script_state,
const RequestInfo& request,
const CacheQueryOptions& options,
ExceptionState& exception_state) {
- ASSERT(!request.isNull());
+ DCHECK(!request.isNull());
if (request.isRequest())
return MatchImpl(script_state, request.getAsRequest(), options);
Request* new_request =
@@ -407,7 +407,7 @@ ScriptPromise Cache::matchAll(ScriptState* script_state,
const RequestInfo& request,
const CacheQueryOptions& options,
ExceptionState& exception_state) {
- ASSERT(!request.isNull());
+ DCHECK(!request.isNull());
if (request.isRequest())
return MatchAllImpl(script_state, request.getAsRequest(), options);
Request* new_request =
@@ -420,7 +420,7 @@ ScriptPromise Cache::matchAll(ScriptState* script_state,
ScriptPromise Cache::add(ScriptState* script_state,
const RequestInfo& request,
ExceptionState& exception_state) {
- ASSERT(!request.isNull());
+ DCHECK(!request.isNull());
HeapVector<Member<Request>> requests;
if (request.isRequest()) {
requests.push_back(request.getAsRequest());
@@ -456,7 +456,7 @@ ScriptPromise Cache::deleteFunction(ScriptState* script_state,
const RequestInfo& request,
const CacheQueryOptions& options,
ExceptionState& exception_state) {
- ASSERT(!request.isNull());
+ DCHECK(!request.isNull());
if (request.isRequest())
return DeleteImpl(script_state, request.getAsRequest(), options);
Request* new_request =
@@ -470,7 +470,7 @@ ScriptPromise Cache::put(ScriptState* script_state,
const RequestInfo& request,
Response* response,
ExceptionState& exception_state) {
- ASSERT(!request.isNull());
+ DCHECK(!request.isNull());
if (request.isRequest())
return PutImpl(script_state,
HeapVector<Member<Request>>(1, request.getAsRequest()),
@@ -491,7 +491,7 @@ ScriptPromise Cache::keys(ScriptState* script_state,
const RequestInfo& request,
const CacheQueryOptions& options,
ExceptionState& exception_state) {
- ASSERT(!request.isNull());
+ DCHECK(!request.isNull());
if (request.isRequest())
return KeysImpl(script_state, request.getAsRequest(), options);
Request* new_request =
@@ -637,7 +637,7 @@ ScriptPromise Cache::PutImpl(ScriptState* script_state,
"' is unsupported");
return promise;
}
- ASSERT(!requests[i]->HasBody());
+ DCHECK(!requests[i]->HasBody());
if (VaryHeaderContainsAsterisk(responses[i])) {
barrier_callback->OnError("Vary header contains *");

Powered by Google App Engine
This is Rietveld 408576698