third_party/WebKit/Source/modules/webgl/WebGLBuffer.cpp - Issue 2862963003: Replace ASSERT with DCHECK in modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLBuffer.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)

Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webgl/WebGLBuffer.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLBuffer.cpp b/third_party/WebKit/Source/modules/webgl/WebGLBuffer.cpp

index 42d886924f5962a1096222f14237a3801b181650..0ec9adbcdcdeb9cb9a6eec157a53a77c9442c173 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLBuffer.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLBuffer.cpp

@@ -53,7 +53,7 @@ void WebGLBuffer::DeleteObjectImpl(gpu::gles2::GLES2Interface* gl) {

void WebGLBuffer::SetInitialTarget(GLenum target) {

// WebGL restricts the ability to bind buffers to multiple targets based on

// it's initial bind point.

- ASSERT(!initial_target_);

+ DCHECK(!initial_target_);

initial_target_ = target;

}