third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp - Issue 2862963003: Replace ASSERT with DCHECK in modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)

Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.cpp ('k') | third_party/WebKit/Source/modules/csspaint/PaintWorkletTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp

diff --git a/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp b/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp

index 988d9a6f655619e79e887a1255f00c068170194d..20c8688b9b8949bd3a2610b857ddb814d70c7b69 100644

--- a/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp

+++ b/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp

@@ -77,7 +77,7 @@ void PaintWorkletGlobalScope::registerPaint(const String& name,

v8::Isolate* isolate = ScriptController()->GetScriptState()->GetIsolate();

v8::Local<v8::Context> context = ScriptController()->GetContext();

- ASSERT(ctor_value.V8Value()->IsFunction());

+ DCHECK(ctor_value.V8Value()->IsFunction());

v8::Local<v8::Function> constructor =

v8::Local<v8::Function>::Cast(ctor_value.V8Value());