third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp - Issue 2862963003: Replace ASSERT with DCHECK in modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)

Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp ('k') | third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp b/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp

index cd9d08963fa4fa47d7e58357d30f1704ce2da30e..68d95e023001903c51d8d192380b3922a5906f5b 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp

@@ -19,8 +19,8 @@ PresentationConnectionCallbacks::PresentationConnectionCallbacks(

ScriptPromiseResolver* resolver,

PresentationRequest* request)

: resolver_(resolver), request_(request), connection_(nullptr) {

- ASSERT(resolver_);

- ASSERT(request_);

+ DCHECK(resolver_);

+ DCHECK(request_);

}

void PresentationConnectionCallbacks::OnSuccess(