third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp - Issue 2862963003: Replace ASSERT with DCHECK in modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)

Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

index 2ec1b57e49091ab3f7ded17de280a3f6fed55580..19c6f1e08ef61c7205c778839766f4f0eaeecca5 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

@@ -44,7 +44,7 @@ class RespondWithObserver::ThenFunction final : public ScriptFunction {

resolve_type_(type) {}

ScriptValue Call(ScriptValue value) override {

- ASSERT(observer_);

+ DCHECK(observer_);

ASSERT(resolve_type_ == kFulfilled || resolve_type_ == kRejected);

if (resolve_type_ == kRejected) {

observer_->ResponseWasRejected(

@@ -76,7 +76,7 @@ void RespondWithObserver::WillDispatchEvent() {

void RespondWithObserver::DidDispatchEvent(

DispatchEventResult dispatch_result) {

- ASSERT(GetExecutionContext());

+ DCHECK(GetExecutionContext());

if (state_ != kInitial)

return;