Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: third_party/WebKit/Source/modules/encoding/TextDecoder.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)
Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/encoding/TextDecoder.cpp
diff --git a/third_party/WebKit/Source/modules/encoding/TextDecoder.cpp b/third_party/WebKit/Source/modules/encoding/TextDecoder.cpp
index b552a9bd359a96872bc9e905902f2d6c0af43752..26745c830af575d5a8e2dcd76b2f5cf382349e63 100644
--- a/third_party/WebKit/Source/modules/encoding/TextDecoder.cpp
+++ b/third_party/WebKit/Source/modules/encoding/TextDecoder.cpp
@@ -79,14 +79,14 @@ String TextDecoder::encoding() const {
String TextDecoder::decode(const BufferSource& input,
const TextDecodeOptions& options,
ExceptionState& exception_state) {
- ASSERT(!input.isNull());
+ DCHECK(!input.isNull());
if (input.isArrayBufferView()) {
const char* start = static_cast<const char*>(
input.getAsArrayBufferView().View()->BaseAddress());
size_t length = input.getAsArrayBufferView().View()->byteLength();
return decode(start, length, options, exception_state);
}
- ASSERT(input.isArrayBuffer());
+ DCHECK(input.isArrayBuffer());
const char* start =
static_cast<const char*>(input.getAsArrayBuffer()->Data());
size_t length = input.getAsArrayBuffer()->ByteLength();

Powered by Google App Engine
This is Rietveld 408576698