Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Unified Diff: third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)
Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp
diff --git a/third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp b/third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp
index b587a1eda3c760f8b3578180f9c0d79586d27a90..2541781cfe4af95cac4d675cb9352d95babe21e3 100644
--- a/third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp
+++ b/third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp
@@ -86,7 +86,7 @@ bool SpeechSynthesis::paused() const {
void SpeechSynthesis::StartSpeakingImmediately() {
SpeechSynthesisUtterance* utterance = CurrentSpeechUtterance();
- ASSERT(utterance);
+ DCHECK(utterance);
utterance->SetStartTime(MonotonicallyIncreasingTime());
is_paused_ = false;
@@ -94,7 +94,7 @@ void SpeechSynthesis::StartSpeakingImmediately() {
}
void SpeechSynthesis::speak(SpeechSynthesisUtterance* utterance) {
- ASSERT(utterance);
+ DCHECK(utterance);
utterance_queue_.push_back(utterance);
@@ -138,7 +138,7 @@ void SpeechSynthesis::FireEvent(const AtomicString& type,
void SpeechSynthesis::HandleSpeakingCompleted(
SpeechSynthesisUtterance* utterance,
bool error_occurred) {
- ASSERT(utterance);
+ DCHECK(utterance);
bool should_start_speaking = false;
// If the utterance that completed was the one we're currently speaking,

Powered by Google App Engine
This is Rietveld 408576698