third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp - Issue 2862963003: Replace ASSERT with DCHECK in modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)

Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

index 96ba62692ef30248c2d86476d4d28c0bae9193f1..d25cec8e9cefa017f222d834790c951ec84244c2 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

@@ -66,7 +66,7 @@ void ServiceWorkerRegistration::SetActive(

ServiceWorkerRegistration* ServiceWorkerRegistration::GetOrCreate(

ExecutionContext* execution_context,

std::unique_ptr<WebServiceWorkerRegistration::Handle> handle) {

- ASSERT(handle);

+ DCHECK(handle);

ServiceWorkerRegistration* existing_registration =

static_cast<ServiceWorkerRegistration*>(handle->Registration()->Proxy());

@@ -133,8 +133,8 @@ ServiceWorkerRegistration::ServiceWorkerRegistration(

: ContextLifecycleObserver(execution_context),

handle_(std::move(handle)),

stopped_(false) {

- ASSERT(handle_);

- ASSERT(!handle_->Registration()->Proxy());

+ DCHECK(handle_);

+ DCHECK(!handle_->Registration()->Proxy());

if (!execution_context)

return;