third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp - Issue 2862963003: Replace ASSERT with DCHECK in modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)

Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

index a4d00d3e697ae281a41f98914adf6dae3faccaad..a001e4ecd9d5e14746a35627f155eaecc29787b2 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp

@@ -316,7 +316,7 @@ WebGLFramebuffer::WebGLAttachment* WebGLFramebuffer::GetAttachment(

void WebGLFramebuffer::RemoveAttachmentFromBoundFramebuffer(

GLenum target,

WebGLSharedObject* attachment) {

- ASSERT(IsBound(target));

+ DCHECK(IsBound(target));

if (!object_)

return;

if (!attachment)