Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)
Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
index eab464635e00b80c883d9eaec819fcbb1398d894..9afc9f60b57fa4bd9e203f85f47c28d9b929b58c 100644
--- a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
@@ -156,7 +156,7 @@ PresentationConnection::PresentationConnection(LocalFrame* frame,
proxy_(nullptr) {}
PresentationConnection::~PresentationConnection() {
- ASSERT(!blob_loader_);
+ DCHECK(!blob_loader_);
}
void PresentationConnection::BindProxy(
@@ -170,9 +170,9 @@ PresentationConnection* PresentationConnection::Take(
ScriptPromiseResolver* resolver,
const WebPresentationInfo& presentation_info,
PresentationRequest* request) {
- ASSERT(resolver);
- ASSERT(request);
- ASSERT(resolver->GetExecutionContext()->IsDocument());
+ DCHECK(resolver);
+ DCHECK(request);
+ DCHECK(resolver->GetExecutionContext()->IsDocument());
Document* document = ToDocument(resolver->GetExecutionContext());
if (!document->GetFrame())
@@ -191,8 +191,8 @@ PresentationConnection* PresentationConnection::Take(
PresentationController* controller,
const WebPresentationInfo& presentation_info,
PresentationRequest* request) {
- ASSERT(controller);
- ASSERT(request);
+ DCHECK(controller);
+ DCHECK(request);
PresentationConnection* connection = new PresentationConnection(
controller->GetFrame(), presentation_info.id, presentation_info.url);
@@ -294,7 +294,7 @@ void PresentationConnection::send(
}
void PresentationConnection::send(Blob* data, ExceptionState& exception_state) {
- ASSERT(data);
+ DCHECK(data);
if (!CanSendMessage(exception_state))
return;
@@ -332,7 +332,7 @@ void PresentationConnection::HandleMessageQueue() {
messages_.pop_front();
break;
case kMessageTypeBlob:
- ASSERT(!blob_loader_);
+ DCHECK(!blob_loader_);
blob_loader_ = new BlobLoader(message->blob_data_handle, this);
break;
}

Powered by Google App Engine
This is Rietveld 408576698