third_party/WebKit/Source/modules/speech/testing/PlatformSpeechSynthesizerMock.cpp - Issue 2862963003: Replace ASSERT with DCHECK in modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/speech/testing/PlatformSpeechSynthesizerMock.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)

Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/speech/testing/PlatformSpeechSynthesizerMock.cpp

diff --git a/third_party/WebKit/Source/modules/speech/testing/PlatformSpeechSynthesizerMock.cpp b/third_party/WebKit/Source/modules/speech/testing/PlatformSpeechSynthesizerMock.cpp

index e30b1a6734dbcd163647ee8935d6d97f53a3a115..d5feafba42b399a094f6bc8c4dcdefa02b01f29e 100644

--- a/third_party/WebKit/Source/modules/speech/testing/PlatformSpeechSynthesizerMock.cpp

+++ b/third_party/WebKit/Source/modules/speech/testing/PlatformSpeechSynthesizerMock.cpp

@@ -51,14 +51,14 @@ PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock(

PlatformSpeechSynthesizerMock::~PlatformSpeechSynthesizerMock() {}

void PlatformSpeechSynthesizerMock::SpeakingErrorOccurred(TimerBase*) {

- ASSERT(current_utterance_);

+ DCHECK(current_utterance_);

Client()->SpeakingErrorOccurred(current_utterance_);

SpeakNext();

}

void PlatformSpeechSynthesizerMock::SpeakingFinished(TimerBase*) {

- ASSERT(current_utterance_);

+ DCHECK(current_utterance_);

Client()->DidFinishSpeaking(current_utterance_);

SpeakNext();

}

@@ -99,7 +99,7 @@ void PlatformSpeechSynthesizerMock::Speak(

}

void PlatformSpeechSynthesizerMock::SpeakNow() {

- ASSERT(current_utterance_);

+ DCHECK(current_utterance_);

Client()->DidStartSpeaking(current_utterance_);

// Fire a fake word and then sentence boundary event.