Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed)

Created:
7 years, 6 months ago by Ryan Sleevi
Modified:
7 years, 6 months ago
CC:
chromium-reviews, jam, weitaosu+watch_chromium.org, sergeyu+watch_chromium.org, tzik+watch_chromium.org, amit, ahutter, browser-components-watch_chromium.org, sail+watch_chromium.org, Raman Kakilate, kinuko+watch, native-client-reviews_googlegroups.com, Ilya Sherman, markusheintz_, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, vsevik, jar (doing other things), benjhayden+dwatch_chromium.org, kkania, dbeam+watch-autofill_chromium.org, apatrick_chromium, rmsousa+watch_chromium.org, joi+watch-content_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, tim (not reviewing), dbeam+watch-options_chromium.org, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, wez+watch_chromium.org, Raghu Simha, sanjeevr, feature-media-reviews_chromium.org, pam+watch_chromium.org, asvitkine+watch_chromium.org, Albert Bodenhamer, haitaol1, alexeypa+watch_chromium.org, rouslan+autofillwatch_chromium.org, gavinp+disk_chromium.org, michaeln, hclam+watch_chromium.org, akalin, tfarina, yurys, garykac+watch_chromium.org, benquan, eroman, robertshield, Dane Wallinga, dyu1, estade+watch_chromium.org, cc-bugs_chromium.org, James Su, mmenke, pfeldman
Visibility:
Public.

Description

Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" This upates calls to bound temporary objects to also use get(). While it has the same semantic equivalence to the existing code, this generally represents a dangerous pattern - indeed, part of the whole motivation for this change is to make this anti-pattern very visible to authors. This change simply updates all of the call sites, to allow the "operator T*" to be removed and preventing new instances. The existing instances will then be reviewed for "suspicious" changes and updated to use/pass scoped_refptr<T> rather than T*, as appropriate. BUG=110610 TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205560

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1438 lines, -1166 lines) Patch
M apps/app_restore_service.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M apps/shell_window_geometry_cache_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M base/files/file_path_watcher_linux.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M base/files/important_file_writer_unittest.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M base/prefs/json_pref_store_unittest.cc View 1 2 3 6 chunks +8 lines, -14 lines 0 comments Download
M base/prefs/pref_service_builder.cc View 1 chunk +13 lines, -14 lines 0 comments Download
M base/prefs/testing_pref_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/prefs/testing_pref_service.cc View 1 chunk +16 lines, -18 lines 0 comments Download
M base/task_runner_util_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/base/worker_pool.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/image_raster_worker_pool.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M cc/resources/pixel_buffer_raster_worker_pool.cc View 1 2 3 10 chunks +13 lines, -11 lines 0 comments Download
M cc/resources/raster_worker_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/raster_worker_pool.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/raster_worker_pool_unittest.cc View 1 chunk +10 lines, -11 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/extension_app_provider.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 7 chunks +26 lines, -13 lines 0 comments Download
M chrome/browser/background/background_application_list_model.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/background/background_application_list_model_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/background/background_contents_service.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data/cookies_tree_model_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/mock_browsing_data_quota_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_plugin_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/component_updater_service.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/content_settings/content_settings_browsertest.cc View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/content_settings/content_settings_internal_extension_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/cookie_settings_unittest.cc View 1 chunk +12 lines, -11 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_adb_bridge.cc View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/active_tab_permission_granter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_apitest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/dial/dial_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/identity_apitest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 1 2 3 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/page_capture/page_capture_api.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/preference/preference_helpers.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/storage/managed_value_store_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 1 2 3 3 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/extensions/app_sync_bundle.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/blacklist.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/blacklist_unittest.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/convert_web_app_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/crx_installer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/event_router_forwarder_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_apitest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_context_menu_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_disabled_ui_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_keybinding_registry.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_protocols_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 3 8 chunks +11 lines, -14 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 3 6 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_startup_browsertest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_sync_bundle.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/installed_loader.cc View 1 2 3 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/extensions/menu_manager_unittest.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/page_action_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/permissions_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/permissions_updater_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker_unittest.cc View 1 2 3 1 chunk +8 lines, -6 lines 0 comments Download
M chrome/browser/extensions/standard_management_policy_provider_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/unpacked_installer.cc View 1 2 3 4 chunks +12 lines, -20 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/updater/safe_manifest_parser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/user_script_listener.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/webstore_install_helper.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/favicon/favicon_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_service.cc View 6 chunks +30 lines, -14 lines 0 comments Download
M chrome/browser/history/shortcuts_backend_unittest.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/history/top_sites_backend.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/importer/external_process_importer_client.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/importer/firefox_importer_browsertest.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/memory_purger.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_log.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_browser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/pnacl_translation_cache.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/net/proxy_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/transport_security_persister.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/notifications/message_center_settings_controller.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_form_manager.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 3 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/prefs/pref_service_syncable.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_service_syncable_builder.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/printing/print_dialog_gtk.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/process_singleton_linux_unittest.cc View 1 2 3 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 2 3 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 8 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 2 3 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/sandboxed_zip_analyzer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/two_phase_uploader_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/safe_json_parser.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/service/service_process_control.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/signin/chrome_signin_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/extension_api/tts_engine_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/passwords_helper.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service_mock_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service_sync_unittest.cc View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_metadata_store.cc View 1 2 3 1 chunk +8 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/local_file_sync_service.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/thumbnails/content_based_thumbnailing_algorithm.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/thumbnails/content_based_thumbnailing_algorithm_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/thumbnails/simple_thumbnail_crop.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/collected_cookies_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/pdf/pdf_unsupported_feature.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper_unittest.cc View 1 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/tabs/tab_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/toolbar/action_box_button_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/command_handler.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/flash_ui.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/nacl_ui.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_handler.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/password_manager_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/uber/uber_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/version_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_resource/json_asynchronous_unpacker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/cancelable_task_tracker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/cancelable_task_tracker_unittest.cc View 3 chunks +16 lines, -19 lines 0 comments Download
M chrome/common/extensions/extension_set.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/sync_type_unittest.cc View 11 chunks +13 lines, -13 lines 0 comments Download
M chrome/common/service_process_util_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/nacl/nacl_ipc_adapter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/nacl/nacl_listener.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client_unittest.cc View 10 chunks +71 lines, -42 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_auth.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/net/service_url_request_context.cc View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/service/service_ipc_server.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/service/service_process.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/service/service_process_prefs_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/automation_proxy.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/test/base/testing_pref_service_syncable.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/adb_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/reliability/automated_ui_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/reliability/automated_ui_tests.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/reliability/page_load_test.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/profile_import_handler.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/webdata/common/web_data_service_base.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/appcache/chrome_appcache_service.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/appcache/chrome_appcache_service_unittest.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M content/browser/devtools/devtools_http_handler_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/devtools_manager_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/dom_storage/dom_storage_context_impl.cc View 1 2 3 1 chunk +6 lines, -5 lines 0 comments Download
M content/browser/fileapi/file_system_browsertest.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/geolocation/fake_access_token_store.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/shader_disk_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_browsertest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_factory.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M content/browser/indexed_db/indexed_db_quota_client_unittest.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M content/browser/indexed_db/indexed_db_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/webidbdatabase_impl.cc View 1 2 3 13 chunks +16 lines, -16 lines 0 comments Download
M content/browser/loader/redirect_to_file_resource_handler.cc View 1 2 3 2 chunks +8 lines, -7 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/plugin_loader_posix.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_input_device_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 1 chunk +14 lines, -8 lines 0 comments Download
M content/browser/speech/speech_recognition_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/speech_recognizer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/storage_partition_impl.cc View 2 chunks +15 lines, -11 lines 0 comments Download
M content/browser/storage_partition_impl_map.cc View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/streams/stream_handle_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/web_contents/navigation_controller_impl_unittest.cc View 1 2 3 5 chunks +10 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_screenshot_manager.cc View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M content/child/child_process.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_thread.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/input_event_filter.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_dependency_factory.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_file_io_host.cc View 7 chunks +19 lines, -9 lines 0 comments Download
M content/renderer/pepper/pepper_platform_audio_input_impl.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_audio_output_impl.cc View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 chunks +7 lines, -6 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_devtools_frontend.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/shell_url_request_context_getter.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M content/test/webrtc_audio_device_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_egl.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_share_group.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/buffer_manager.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M ipc/ipc_channel_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 1 2 3 6 chunks +29 lines, -14 lines 0 comments Download
M ipc/ipc_sync_message_filter.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/unix_domain_socket_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_manager_base.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 1 2 3 4 chunks +17 lines, -9 lines 0 comments Download
M media/filters/video_renderer_base_unittest.cc View 1 2 3 6 chunks +7 lines, -7 lines 0 comments Download
M media/tools/shader_bench/shader_bench.cc View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M net/base/upload_data_stream_unittest.cc View 9 chunks +49 lines, -25 lines 0 comments Download
M net/base/upload_file_element_reader_unittest.cc View 1 2 3 4 chunks +24 lines, -12 lines 0 comments Download
M net/disk_cache/backend_unittest.cc View 1 2 3 9 chunks +57 lines, -26 lines 0 comments Download
M net/disk_cache/disk_cache_perftest.cc View 1 2 3 2 chunks +19 lines, -7 lines 0 comments Download
M net/disk_cache/disk_cache_test_base.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/disk_cache/disk_cache_test_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/entry_unittest.cc View 1 2 3 5 chunks +13 lines, -9 lines 0 comments Download
M net/disk_cache/simple/simple_backend_impl.cc View 1 2 3 1 chunk +5 lines, -6 lines 0 comments Download
M net/disk_cache/simple/simple_index_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/stress_cache.cc View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M net/http/http_network_transaction_spdy2_unittest.cc View 3 chunks +15 lines, -6 lines 0 comments Download
M net/http/http_network_transaction_spdy3_unittest.cc View 3 chunks +15 lines, -6 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_stream_parser_unittest.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M net/proxy/network_delegate_error_observer_unittest.cc View 1 2 3 2 chunks +16 lines, -13 lines 0 comments Download
M net/proxy/proxy_config_service_linux_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_service_v8.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_network_transaction_spdy2_unittest.cc View 2 chunks +12 lines, -6 lines 0 comments Download
M net/spdy/spdy_network_transaction_spdy3_unittest.cc View 2 chunks +12 lines, -6 lines 0 comments Download
M net/tools/crash_cache/crash_cache.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/dump_cache/simple_cache_dumper.cc View 1 2 3 1 chunk +9 lines, -3 lines 0 comments Download
M net/tools/net_watcher/net_watcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/url_request/url_fetcher_impl_unittest.cc View 1 2 3 15 chunks +17 lines, -20 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 2 3 1 chunk +10 lines, -4 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/client_context.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/chromoting_host_context_unittest.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M ui/compositor/layer.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M webkit/browser/appcache/appcache_storage_impl_unittest.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M webkit/browser/blob/blob_storage_context.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/blob/blob_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/blob/mock_blob_url_request_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/database_quota_client_unittest.cc View 1 2 3 4 chunks +8 lines, -12 lines 0 comments Download
M webkit/browser/database/database_tracker_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/dom_storage/dom_storage_area_unittest.cc View 1 2 3 5 chunks +20 lines, -20 lines 0 comments Download
M webkit/browser/dom_storage/dom_storage_context_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/copy_or_move_operation_delegate_unittest.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M webkit/browser/fileapi/file_system_context_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_usage_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/local_file_system_operation_unittest.cc View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download
M webkit/browser/fileapi/local_file_system_operation_write_unittest.cc View 1 2 3 1 chunk +6 lines, -5 lines 0 comments Download
M webkit/browser/fileapi/mock_file_change_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/mock_file_system_context.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util_unittest.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M webkit/browser/fileapi/sandbox_mount_point_provider_unittest.cc View 1 2 3 1 chunk +5 lines, -6 lines 0 comments Download
M webkit/browser/fileapi/syncable/canned_syncable_file_system.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/syncable/local_file_change_tracker_unittest.cc View 1 2 3 1 chunk +5 lines, -4 lines 0 comments Download
M webkit/browser/fileapi/syncable/syncable_file_operation_runner_unittest.cc View 1 1 chunk +13 lines, -12 lines 0 comments Download
M webkit/browser/fileapi/syncable/syncable_file_system_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M webkit/browser/fileapi/syncable/syncable_file_system_util_unittest.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/browser/quota/mock_quota_manager_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/quota/quota_manager_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/common/blob/scoped_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/resource_request_body_unittest.cc View 1 2 3 8 chunks +10 lines, -8 lines 0 comments Download
M webkit/plugins/ppapi/host_globals.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/quota_file_io.cc View 1 2 3 3 chunks +11 lines, -6 lines 0 comments Download
M webkit/renderer/media/webmediaplayer_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/renderer/media/webmediaplayer_params.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/simple_appcache_system.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/support/simple_resource_loader_bridge.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/support/test_shell_request_context.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ryan Sleevi
TBR. As scary as this may look, it's semantically equivalent to the original code - ...
7 years, 6 months ago (2013-06-08 01:34:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/15984016/1
7 years, 6 months ago (2013-06-08 01:35:01 UTC) #2
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=135932
7 years, 6 months ago (2013-06-08 03:30:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/15984016/1
7 years, 6 months ago (2013-06-08 09:10:22 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-08 09:46:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/15984016/31001
7 years, 6 months ago (2013-06-10 19:12:00 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=8231
7 years, 6 months ago (2013-06-11 06:30:37 UTC) #7
Ryan Sleevi
Committed patchset #4 manually as r205560 (presubmit successful).
7 years, 6 months ago (2013-06-11 16:46:52 UTC) #8
darin (slow to review)
7 years, 6 months ago (2013-06-12 00:08:36 UTC) #9
Message was sent while issue was closed.
OK, LGTM

Powered by Google App Engine
This is Rietveld 408576698