chrome/browser/extensions/api/identity/identity_apitest.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/identity_apitest.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api_unittest.cc ('k') | chrome/browser/extensions/api/management/management_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/identity/identity_apitest.cc

diff --git a/chrome/browser/extensions/api/identity/identity_apitest.cc b/chrome/browser/extensions/api/identity/identity_apitest.cc

index 1540db0c7bf8c21efd739799d0a1c28b55c7d247..468a1e99b24adb32b01e914891199e03ec931c34 100644

--- a/chrome/browser/extensions/api/identity/identity_apitest.cc

+++ b/chrome/browser/extensions/api/identity/identity_apitest.cc

@@ -927,7 +927,7 @@ class RemoveCachedAuthTokenFunctionTest : public ExtensionBrowserTest {

bool InvalidateDefaultToken() {

scoped_refptr<IdentityRemoveCachedAuthTokenFunction> func(

new IdentityRemoveCachedAuthTokenFunction);

- func->set_extension(utils::CreateEmptyExtension(kExtensionId));

+ func->set_extension(utils::CreateEmptyExtension(kExtensionId).get());

return utils::RunFunction(

func.get(),

std::string("[{\"token\": \"") + kAccessToken + "\"}]",

@@ -1061,8 +1061,8 @@ IN_PROC_BROWSER_TEST_F(LaunchWebAuthFlowFunctionTest, LoadFailed) {

std::string args = "[{\"interactive\": true, \"url\": \"" +

auth_url.spec() + "\"}]";

- std::string error = utils::RunFunctionAndReturnError(function, args,

- browser());

+ std::string error =

+ utils::RunFunctionAndReturnError(function.get(), args, browser());

EXPECT_EQ(std::string(errors::kPageLoadFailure), error);

}