chrome/service/cloud_print/cloud_print_auth.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/cloud_print/cloud_print_auth.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/chrome_content_renderer_client_unittest.cc ('k') | chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/service/cloud_print/cloud_print_auth.cc

diff --git a/chrome/service/cloud_print/cloud_print_auth.cc b/chrome/service/cloud_print/cloud_print_auth.cc

index bc9f36c284726651f48ca25eb9183b3a62dd06ed..3505a9140db6fe6f92106d08bf209decd4f1da9a 100644

--- a/chrome/service/cloud_print/cloud_print_auth.cc

+++ b/chrome/service/cloud_print/cloud_print_auth.cc

@@ -38,9 +38,10 @@ void CloudPrintAuth::AuthenticateWithLsid(

VLOG(1) << "CP_AUTH: Authenticating with LSID";

scoped_refptr<ServiceGaiaAuthenticator> gaia_auth_for_print(

new ServiceGaiaAuthenticator(

- kProxyAuthUserAgent, kCloudPrintGaiaServiceId,

+ kProxyAuthUserAgent,

+ kCloudPrintGaiaServiceId,

GaiaUrls::GetInstance()->client_login_url(),

- g_service_process->io_thread()->message_loop_proxy()));

+ g_service_process->io_thread()->message_loop_proxy().get()));

gaia_auth_for_print->set_message_loop(base::MessageLoop::current());

if (gaia_auth_for_print->AuthenticateWithLsid(lsid)) {

// Stash away the user email so we can save it in prefs.