net/http/http_network_transaction_spdy2_unittest.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_transaction_spdy2_unittest.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_network_transaction_spdy2_unittest.cc

diff --git a/net/http/http_network_transaction_spdy2_unittest.cc b/net/http/http_network_transaction_spdy2_unittest.cc

index 6f5c95520abc52c5088433b41061b85d73c47129..d9cbb0ace42797fa18421eed8151673a75f7d089 100644

--- a/net/http/http_network_transaction_spdy2_unittest.cc

+++ b/net/http/http_network_transaction_spdy2_unittest.cc

@@ -7551,8 +7551,11 @@ TEST_F(HttpNetworkTransactionSpdy2Test, UploadFileSmallerThanLength) {

ScopedVector<UploadElementReader> element_readers;

element_readers.push_back(

- new UploadFileElementReader(base::MessageLoopProxy::current(),

- temp_file_path, 0, kuint64max, base::Time()));

+ new UploadFileElementReader(base::MessageLoopProxy::current().get(),

+ temp_file_path,

+ 0,

+ kuint64max,

+ base::Time()));

UploadDataStream upload_data_stream(&element_readers, 0);

HttpRequestInfo request;

@@ -7605,8 +7608,11 @@ TEST_F(HttpNetworkTransactionSpdy2Test, UploadUnreadableFile) {

ScopedVector<UploadElementReader> element_readers;

element_readers.push_back(

- new UploadFileElementReader(base::MessageLoopProxy::current(),

- temp_file, 0, kuint64max, base::Time()));

+ new UploadFileElementReader(base::MessageLoopProxy::current().get(),

+ temp_file,

+ 0,

+ kuint64max,

+ base::Time()));

UploadDataStream upload_data_stream(&element_readers, 0);

HttpRequestInfo request;

@@ -7662,8 +7668,11 @@ TEST_F(HttpNetworkTransactionSpdy2Test, UnreadableUploadFileAfterAuthRestart) {

ScopedVector<UploadElementReader> element_readers;

element_readers.push_back(

- new UploadFileElementReader(base::MessageLoopProxy::current(),

- temp_file, 0, kuint64max, base::Time()));

+ new UploadFileElementReader(base::MessageLoopProxy::current().get(),

+ temp_file,

+ 0,

+ kuint64max,

+ base::Time()));

UploadDataStream upload_data_stream(&element_readers, 0);

HttpRequestInfo request;

« no previous file with comments | « net/disk_cache/stress_cache.cc ('k') | net/http/http_network_transaction_spdy3_unittest.cc » ('j') | no next file with comments »