chrome/browser/extensions/api/page_capture/page_capture_api.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/page_capture/page_capture_api.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc ('k') | chrome/browser/extensions/api/permissions/permissions_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/page_capture/page_capture_api.cc

diff --git a/chrome/browser/extensions/api/page_capture/page_capture_api.cc b/chrome/browser/extensions/api/page_capture/page_capture_api.cc

index 2d53b2c5d6a001f997f3210ee689d3d83ef497af..62a800e09b253bff8dfb637c8818c80569110b52 100644

--- a/chrome/browser/extensions/api/page_capture/page_capture_api.cc

+++ b/chrome/browser/extensions/api/page_capture/page_capture_api.cc

@@ -103,8 +103,10 @@ void PageCaptureSaveAsMHTMLFunction::TemporaryFileCreated(bool success) {

// Setup a ShareableFileReference so the temporary file gets deleted

// once it is no longer used.

mhtml_file_ = ShareableFileReference::GetOrCreate(

- mhtml_path_, ShareableFileReference::DELETE_ON_FINAL_RELEASE,

- BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE));

+ mhtml_path_,

+ ShareableFileReference::DELETE_ON_FINAL_RELEASE,

+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE)

+ .get());

}

BrowserThread::PostTask(

BrowserThread::UI, FROM_HERE,