chrome/browser/extensions/extension_keybinding_registry.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_keybinding_registry.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_disabled_ui_browsertest.cc ('k') | chrome/browser/extensions/extension_prefs_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_keybinding_registry.cc

diff --git a/chrome/browser/extensions/extension_keybinding_registry.cc b/chrome/browser/extensions/extension_keybinding_registry.cc

index b2a3c84dc4aca3f57317756d3d0ce57c34a8ed13..e5cf544d22a2c25e556032e5dcb2bd6542b8cbce 100644

--- a/chrome/browser/extensions/extension_keybinding_registry.cc

+++ b/chrome/browser/extensions/extension_keybinding_registry.cc

@@ -43,8 +43,8 @@ void ExtensionKeybindingRegistry::Init() {

const ExtensionSet* extensions = service->extensions();

ExtensionSet::const_iterator iter = extensions->begin();

for (; iter != extensions->end(); ++iter)

- if (ExtensionMatchesFilter(*iter))

- AddExtensionKeybinding(*iter, std::string());

+ if (ExtensionMatchesFilter(iter->get()))

+ AddExtensionKeybinding(iter->get(), std::string());

}

bool ExtensionKeybindingRegistry::ShouldIgnoreCommand(