chrome/browser/policy/policy_browsertest.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/policy_browsertest.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_form_manager.cc ('k') | chrome/browser/prefs/chrome_pref_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/policy_browsertest.cc

diff --git a/chrome/browser/policy/policy_browsertest.cc b/chrome/browser/policy/policy_browsertest.cc

index df1716bf4296d95a27bc6f9aaf82494bb91a2421..1cf089ccf73c393146287624dfd79a51c2559b83 100644

--- a/chrome/browser/policy/policy_browsertest.cc

+++ b/chrome/browser/policy/policy_browsertest.cc

@@ -1018,7 +1018,8 @@ IN_PROC_BROWSER_TEST_F(PolicyTest, DisabledPlugins) {

const webkit::WebPluginInfo* flash = GetFlashPlugin(plugins);

if (!flash)

return;

- PluginPrefs* plugin_prefs = PluginPrefs::GetForProfile(browser()->profile());

+ PluginPrefs* plugin_prefs =

+ PluginPrefs::GetForProfile(browser()->profile()).get();

EXPECT_TRUE(plugin_prefs->IsPluginEnabled(*flash));

EXPECT_TRUE(SetPluginEnabled(plugin_prefs, flash, false));

EXPECT_FALSE(plugin_prefs->IsPluginEnabled(*flash));

@@ -1048,7 +1049,8 @@ IN_PROC_BROWSER_TEST_F(PolicyTest, DisabledPluginsExceptions) {

const webkit::WebPluginInfo* flash = GetFlashPlugin(plugins);

if (!flash)

return;

- PluginPrefs* plugin_prefs = PluginPrefs::GetForProfile(browser()->profile());

+ PluginPrefs* plugin_prefs =

+ PluginPrefs::GetForProfile(browser()->profile()).get();

EXPECT_TRUE(plugin_prefs->IsPluginEnabled(*flash));

// Disable all plugins.

@@ -1086,7 +1088,8 @@ IN_PROC_BROWSER_TEST_F(PolicyTest, EnabledPlugins) {

const webkit::WebPluginInfo* flash = GetFlashPlugin(plugins);

if (!flash)

return;

- PluginPrefs* plugin_prefs = PluginPrefs::GetForProfile(browser()->profile());

+ PluginPrefs* plugin_prefs =

+ PluginPrefs::GetForProfile(browser()->profile()).get();

EXPECT_TRUE(plugin_prefs->IsPluginEnabled(*flash));

// The user disables it and then a policy forces it to be enabled.

« no previous file with comments | « chrome/browser/password_manager/password_form_manager.cc ('k') | chrome/browser/prefs/chrome_pref_service_unittest.cc » ('j') | no next file with comments »