Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4201)

Unified Diff: chrome/browser/extensions/installed_loader.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/installed_loader.cc
diff --git a/chrome/browser/extensions/installed_loader.cc b/chrome/browser/extensions/installed_loader.cc
index 01e21372a831a16537d4bb960abe1bc351a5fa68..2fc4b46c78338b3c209c81c0c8c9caf58b27f342 100644
--- a/chrome/browser/extensions/installed_loader.cc
+++ b/chrome/browser/extensions/installed_loader.cc
@@ -302,9 +302,10 @@ void InstalledLoader::LoadAllExtensions() {
(*ex)->manifest_version(), 10);
if (type == Manifest::TYPE_EXTENSION) {
- BackgroundPageType background_page_type = GetBackgroundPageType(*ex);
- UMA_HISTOGRAM_ENUMERATION("Extensions.BackgroundPageType",
- background_page_type, 10);
+ BackgroundPageType background_page_type =
+ GetBackgroundPageType(ex->get());
+ UMA_HISTOGRAM_ENUMERATION(
+ "Extensions.BackgroundPageType", background_page_type, 10);
}
// Using an enumeration shows us the total installed ratio across all users.
@@ -355,16 +356,16 @@ void InstalledLoader::LoadAllExtensions() {
++item_user_count;
ExtensionActionManager* extension_action_manager =
ExtensionActionManager::Get(extension_service_->profile());
- if (extension_action_manager->GetPageAction(**ex))
+ if (extension_action_manager->GetPageAction(*ex->get()))
++page_action_count;
- if (extension_action_manager->GetBrowserAction(**ex))
+ if (extension_action_manager->GetBrowserAction(*ex->get()))
++browser_action_count;
- if (extensions::ManagedModeInfo::IsContentPack(*ex))
+ if (extensions::ManagedModeInfo::IsContentPack(ex->get()))
++content_pack_count;
extension_service_->RecordPermissionMessagesHistogram(
- *ex, "Extensions.Permissions_Load");
+ ex->get(), "Extensions.Permissions_Load");
}
const ExtensionSet* disabled_extensions =
extension_service_->disabled_extensions();
« no previous file with comments | « chrome/browser/extensions/extension_toolbar_model.cc ('k') | chrome/browser/extensions/menu_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698