chrome/browser/devtools/devtools_adb_bridge.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_adb_bridge.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/host_content_settings_map_unittest.cc ('k') | chrome/browser/devtools/devtools_sanity_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/devtools_adb_bridge.cc

diff --git a/chrome/browser/devtools/devtools_adb_bridge.cc b/chrome/browser/devtools/devtools_adb_bridge.cc

index 39b5ecc667da01b126a02e70e098c4e29edb6b75..fb006f19bb5281e644fed10c1909b1d447f8deff 100644

--- a/chrome/browser/devtools/devtools_adb_bridge.cc

+++ b/chrome/browser/devtools/devtools_adb_bridge.cc

@@ -524,9 +524,8 @@ class AdbAttachCommand : public base::RefCounted<AdbAttachCommand> {

else

delegate = new AgentHostDelegate(id, serial_, bridge->adb_thread_,

socket);

- DevToolsWindow::OpenExternalFrontend(bridge->profile_,

- frontend_url_,

- delegate->GetAgentHost());

+ DevToolsWindow::OpenExternalFrontend(

+ bridge->profile_, frontend_url_, delegate->GetAgentHost().get());

}

base::WeakPtr<DevToolsAdbBridge> bridge_;