chrome/browser/extensions/extension_toolbar_model.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_toolbar_model.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_toolbar_model.cc

diff --git a/chrome/browser/extensions/extension_toolbar_model.cc b/chrome/browser/extensions/extension_toolbar_model.cc

index a387e056bdd230b030353172a4c879f9c6037183..7805832c9e13657c816043df4a79c482c74c3c40 100644

--- a/chrome/browser/extensions/extension_toolbar_model.cc

+++ b/chrome/browser/extensions/extension_toolbar_model.cc

@@ -334,7 +334,7 @@ void ExtensionToolbarModel::Populate(

// Create the lists.

for (ExtensionSet::const_iterator it = service_->extensions()->begin();

it != service_->extensions()->end(); ++it) {

- const Extension* extension = *it;

+ const Extension* extension = it->get();

if (!extension_action_manager->GetBrowserAction(*extension))

continue;

if (!extensions::ExtensionActionAPI::GetBrowserActionVisibility(

« no previous file with comments | « chrome/browser/extensions/extension_sync_bundle.cc ('k') | chrome/browser/extensions/installed_loader.cc » ('j') | no next file with comments »