chrome/browser/printing/print_dialog_gtk.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_dialog_gtk.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc ('k') | chrome/browser/process_singleton_linux_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_dialog_gtk.cc

diff --git a/chrome/browser/printing/print_dialog_gtk.cc b/chrome/browser/printing/print_dialog_gtk.cc

index 8960a2544a92ecc19946adc5db03db40b4c3234a..e4a6e5d648280f986a55d6625d1fc9bee556e7bb 100644

--- a/chrome/browser/printing/print_dialog_gtk.cc

+++ b/chrome/browser/printing/print_dialog_gtk.cc

@@ -407,8 +407,10 @@ void PrintDialogGtk::OnJobCompleted(GtkPrintJob* print_job, GError* error) {

if (print_job)

g_object_unref(print_job);

base::FileUtilProxy::Delete(

- BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE),

- path_to_pdf_, false, base::FileUtilProxy::StatusCallback());

+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE).get(),

+ path_to_pdf_,

+ false,

+ base::FileUtilProxy::StatusCallback());

// Printing finished. Matches AddRef() in PrintDocument();

Release();

}