chrome/browser/extensions/extension_startup_browsertest.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_startup_browsertest.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_special_storage_policy_unittest.cc ('k') | chrome/browser/extensions/extension_sync_bundle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_startup_browsertest.cc

diff --git a/chrome/browser/extensions/extension_startup_browsertest.cc b/chrome/browser/extensions/extension_startup_browsertest.cc

index e45e8657152899262500f562122d748732190886..ada7f891fdcc7ff352125bbf0a4fd774445773e3 100644

--- a/chrome/browser/extensions/extension_startup_browsertest.cc

+++ b/chrome/browser/extensions/extension_startup_browsertest.cc

@@ -189,8 +189,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionsStartupTest, MAYBE_NoFileAccess) {

it != service->extensions()->end(); ++it) {

if ((*it)->location() == extensions::Manifest::COMPONENT)

continue;

- if (service->AllowFileAccess(*it))

- extension_list.push_back(*it);

+ if (service->AllowFileAccess(it->get()))

+ extension_list.push_back(it->get());

}

for (size_t i = 0; i < extension_list.size(); ++i) {