chrome/browser/extensions/api/management/management_api.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_api.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/identity/identity_apitest.cc ('k') | chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/management_api.cc

diff --git a/chrome/browser/extensions/api/management/management_api.cc b/chrome/browser/extensions/api/management/management_api.cc

index 4ad1ee61443d06340b96504f0a390beba46e2a01..c855b831cc401773089030694e8da26cd180c341 100644

--- a/chrome/browser/extensions/api/management/management_api.cc

+++ b/chrome/browser/extensions/api/management/management_api.cc

@@ -207,7 +207,7 @@ void AddExtensionInfo(const ExtensionSet& extensions,

ExtensionInfoList* extension_list) {

for (ExtensionSet::const_iterator iter = extensions.begin();

iter != extensions.end(); ++iter) {

- const Extension& extension = **iter;

+ const Extension& extension = *iter->get();

if (extension.location() == Manifest::COMPONENT)

continue; // Skip built-in extensions.

@@ -297,10 +297,8 @@ class SafeManifestJSONParser : public UtilityProcessHostClient {

void StartWorkOnIOThread() {

CHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

- UtilityProcessHost* host =

- UtilityProcessHost::Create(

- this,

- base::MessageLoopProxy::current());

+ UtilityProcessHost* host = UtilityProcessHost::Create(

+ this, base::MessageLoopProxy::current().get());

host->EnableZygote();

host->Send(new ChromeUtilityMsg_ParseJSON(manifest_));

}