content/browser/speech/speech_recognition_manager_impl.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/speech/speech_recognition_manager_impl.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | content/browser/speech/speech_recognizer_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/speech/speech_recognition_manager_impl.cc

diff --git a/content/browser/speech/speech_recognition_manager_impl.cc b/content/browser/speech/speech_recognition_manager_impl.cc

index 33cf503f535fde2b7628867f56f4afc8887e4121..03b663c82c601386110350aebcc72c8192cfa90e 100644

--- a/content/browser/speech/speech_recognition_manager_impl.cc

+++ b/content/browser/speech/speech_recognition_manager_impl.cc

@@ -592,7 +592,7 @@ void SpeechRecognitionManagerImpl::ResetCapturingSessionId(

}

void SpeechRecognitionManagerImpl::SessionDelete(Session* session) {

- DCHECK(session->recognizer == NULL || !session->recognizer->IsActive());

+ DCHECK(session->recognizer.get() == NULL || !session->recognizer->IsActive());

if (primary_session_id_ == session->id)

primary_session_id_ = kSessionIDInvalid;

sessions_.erase(session->id);