content/browser/indexed_db/indexed_db_backing_store.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_backing_store.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/in_process_webkit/indexed_db_browsertest.cc ('k') | content/browser/indexed_db/indexed_db_backing_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/indexed_db_backing_store.cc

diff --git a/content/browser/indexed_db/indexed_db_backing_store.cc b/content/browser/indexed_db/indexed_db_backing_store.cc

index 39fc7e2ea5a7978d13427141a3a304b65a51018d..e3b6a43369b235807614276dd7c349a372e01ed1 100644

--- a/content/browser/indexed_db/indexed_db_backing_store.cc

+++ b/content/browser/indexed_db/indexed_db_backing_store.cc

@@ -2619,13 +2619,13 @@ IndexedDBBackingStore::Transaction::~Transaction() {}

void IndexedDBBackingStore::Transaction::begin() {

IDB_TRACE("IndexedDBBackingStore::Transaction::begin");

- DCHECK(!transaction_);

+ DCHECK(!transaction_.get());

transaction_ = LevelDBTransaction::Create(backing_store_->db_.get());

}

bool IndexedDBBackingStore::Transaction::Commit() {

IDB_TRACE("IndexedDBBackingStore::Transaction::commit");

- DCHECK(transaction_);

+ DCHECK(transaction_.get());

bool result = transaction_->Commit();

transaction_ = NULL;

if (!result)

@@ -2635,7 +2635,7 @@ bool IndexedDBBackingStore::Transaction::Commit() {

void IndexedDBBackingStore::Transaction::Rollback() {

IDB_TRACE("IndexedDBBackingStore::Transaction::rollback");

- DCHECK(transaction_);

+ DCHECK(transaction_.get());

transaction_->Rollback();

transaction_ = NULL;

}