chrome/browser/chrome_content_browser_client.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/mock_browsing_data_quota_helper.cc ('k') | chrome/browser/chrome_plugin_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index d545ba3be8b2c47d73cd349e7f6d9b03e9b9f69a..017a8182be2c7b8ef702639c45443925469bae49 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -1685,7 +1685,7 @@ void ChromeContentBrowserClient::RequestDesktopNotificationPermission(

for (ExtensionSet::const_iterator iter = extensions.begin();

iter != extensions.end(); ++iter) {

if (notification_service->IsExtensionEnabled((*iter)->id())) {

- extension = *iter;

+ extension = iter->get();

break;

}

@@ -1978,7 +1978,7 @@ void ChromeContentBrowserClient::OverrideWebkitPrefs(

#else

// The user stylesheet watcher may not exist in a testing profile.

UserStyleSheetWatcher* user_style_sheet_watcher =

- UserStyleSheetWatcherFactory::GetForProfile(profile);

+ UserStyleSheetWatcherFactory::GetForProfile(profile).get();

if (user_style_sheet_watcher) {

web_prefs->user_style_sheet_enabled = true;

web_prefs->user_style_sheet_location =

« no previous file with comments | « chrome/browser/browsing_data/mock_browsing_data_quota_helper.cc ('k') | chrome/browser/chrome_plugin_browsertest.cc » ('j') | no next file with comments »