Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2300)

Unified Diff: chrome/browser/password_manager/password_form_manager.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_form_manager.cc
diff --git a/chrome/browser/password_manager/password_form_manager.cc b/chrome/browser/password_manager/password_form_manager.cc
index 0389792d24e07cfe84b2be6d55570cde4456cf23..eac88b21ee5ef0661f50ab6570fef3cde2c5b0e6 100644
--- a/chrome/browser/password_manager/password_form_manager.cc
+++ b/chrome/browser/password_manager/password_form_manager.cc
@@ -127,7 +127,7 @@ void PasswordFormManager::PermanentlyBlacklist() {
if (!best_matches_.empty()) {
PasswordFormMap::const_iterator iter;
PasswordStore* password_store = PasswordStoreFactory::GetForProfile(
- profile_, Profile::EXPLICIT_ACCESS);
+ profile_, Profile::EXPLICIT_ACCESS).get();
if (!password_store) {
NOTREACHED();
return;
@@ -240,7 +240,7 @@ void PasswordFormManager::FetchMatchingLoginsFromPasswordStore() {
DCHECK_EQ(state_, PRE_MATCHING_PHASE);
state_ = MATCHING_PHASE;
PasswordStore* password_store = PasswordStoreFactory::GetForProfile(
- profile_, Profile::EXPLICIT_ACCESS);
+ profile_, Profile::EXPLICIT_ACCESS).get();
if (!password_store) {
NOTREACHED();
return;
@@ -398,7 +398,7 @@ void PasswordFormManager::SaveAsNewLogin(bool reset_preferred_login) {
DCHECK(!profile_->IsOffTheRecord());
PasswordStore* password_store = PasswordStoreFactory::GetForProfile(
- profile_, Profile::IMPLICIT_ACCESS);
+ profile_, Profile::IMPLICIT_ACCESS).get();
if (!password_store) {
NOTREACHED();
return;
@@ -456,7 +456,7 @@ void PasswordFormManager::UpdateLogin() {
DCHECK(!profile_->IsOffTheRecord());
PasswordStore* password_store = PasswordStoreFactory::GetForProfile(
- profile_, Profile::IMPLICIT_ACCESS);
+ profile_, Profile::IMPLICIT_ACCESS).get();
if (!password_store) {
NOTREACHED();
return;
« no previous file with comments | « chrome/browser/notifications/message_center_settings_controller.cc ('k') | chrome/browser/policy/policy_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698