chrome/browser/extensions/api/preference/preference_helpers.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/preference/preference_helpers.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/permissions/permissions_api.cc ('k') | chrome/browser/extensions/api/storage/managed_value_store_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/preference/preference_helpers.cc

diff --git a/chrome/browser/extensions/api/preference/preference_helpers.cc b/chrome/browser/extensions/api/preference/preference_helpers.cc

index 55297ddef7d37427fb44f6d99407a8d4e4a54733..7b18e784fc821917e01a2813f0a19b4fd0eb2e63 100644

--- a/chrome/browser/extensions/api/preference/preference_helpers.cc

+++ b/chrome/browser/extensions/api/preference/preference_helpers.cc

@@ -99,8 +99,8 @@ void DispatchEventToExtensions(

// TODO(bauerb): Only iterate over registered event listeners.

if (router->ExtensionHasEventListener(extension_id, event_name) &&

(*it)->HasAPIPermission(permission) &&

- (!incognito || IncognitoInfo::IsSplitMode(*it) ||

- extension_service->CanCrossIncognito(*it))) {

+ (!incognito || IncognitoInfo::IsSplitMode(it->get()) ||

+ extension_service->CanCrossIncognito(it->get()))) {

// Inject level of control key-value.

DictionaryValue* dict;

bool rv = args->GetDictionary(0, &dict);

@@ -115,7 +115,7 @@ void DispatchEventToExtensions(

// incognito pref has not alredy been set

Profile* restrict_to_profile = NULL;

bool from_incognito = false;

- if (IncognitoInfo::IsSplitMode(*it)) {

+ if (IncognitoInfo::IsSplitMode(it->get())) {

if (incognito && extension_service->IsIncognitoEnabled(extension_id)) {

restrict_to_profile = profile->GetOffTheRecordProfile();

} else if (!incognito &&