chrome/browser/speech/extension_api/tts_engine_extension_api.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/extension_api/tts_engine_extension_api.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/signin/chrome_signin_manager_delegate.cc ('k') | chrome/browser/sync/glue/autofill_data_type_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/speech/extension_api/tts_engine_extension_api.cc

diff --git a/chrome/browser/speech/extension_api/tts_engine_extension_api.cc b/chrome/browser/speech/extension_api/tts_engine_extension_api.cc

index fa7f9440398ac07c8c45cfad67f84ecb7416ab21..ae3fa1d29da7f325838f6a98fe90b1b3dbc69549 100644

--- a/chrome/browser/speech/extension_api/tts_engine_extension_api.cc

+++ b/chrome/browser/speech/extension_api/tts_engine_extension_api.cc

@@ -68,7 +68,7 @@ void GetExtensionVoices(Profile* profile, std::vector<VoiceData>* out_voices) {

const ExtensionSet* extensions = service->extensions();

ExtensionSet::const_iterator iter;

for (iter = extensions->begin(); iter != extensions->end(); ++iter) {

- const Extension* extension = *iter;

+ const Extension* extension = iter->get();

if (!event_router->ExtensionHasEventListener(

extension->id(), tts_engine_events::kOnSpeak) ||