Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_icon_source.cc ('k') | chrome/browser/ui/webui/flash_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index 50d9e04a6b1de101e8d630c5ddc36e544c7cdc03..f0a00e196984162f129e61061c3db3a2b6483e9c 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -541,7 +541,7 @@ void ExtensionSettingsHandler::ReloadUnpackedExtensions() {
for (ExtensionSet::const_iterator extension = extensions->begin();
extension != extensions->end(); ++extension) {
if (Manifest::IsUnpackedLocation((*extension)->location()))
- unpacked_extensions.push_back(*extension);
+ unpacked_extensions.push_back(extension->get());
}
for (std::vector<const Extension*>::iterator iter =
@@ -567,8 +567,8 @@ void ExtensionSettingsHandler::HandleRequestExtensionsData(
extension != extensions->end(); ++extension) {
if ((*extension)->ShouldDisplayInExtensionSettings()) {
extensions_list->Append(CreateExtensionDetailValue(
- *extension,
- GetInspectablePagesForExtension(*extension, true),
+ extension->get(),
+ GetInspectablePagesForExtension(extension->get(), true),
warnings));
}
}
@@ -577,8 +577,8 @@ void ExtensionSettingsHandler::HandleRequestExtensionsData(
extension != extensions->end(); ++extension) {
if ((*extension)->ShouldDisplayInExtensionSettings()) {
extensions_list->Append(CreateExtensionDetailValue(
- *extension,
- GetInspectablePagesForExtension(*extension, false),
+ extension->get(),
+ GetInspectablePagesForExtension(extension->get(), false),
warnings));
}
}
@@ -588,7 +588,7 @@ void ExtensionSettingsHandler::HandleRequestExtensionsData(
extension != extensions->end(); ++extension) {
if ((*extension)->ShouldDisplayInExtensionSettings()) {
extensions_list->Append(CreateExtensionDetailValue(
- *extension,
+ extension->get(),
empty_pages, // Terminated process has no active pages.
warnings));
}
« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_icon_source.cc ('k') | chrome/browser/ui/webui/flash_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698