chrome/browser/devtools/devtools_window.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/devtools_sanity_browsertest.cc ('k') | chrome/browser/extensions/active_tab_permission_granter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/devtools_window.cc

diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc

index 98a2e25af3039c1f2a8b89cd409e52bb1913f287..78005c09f0f137caebf6f5f6322c72561d5266d1 100644

--- a/chrome/browser/devtools/devtools_window.cc

+++ b/chrome/browser/devtools/devtools_window.cc

@@ -595,11 +595,13 @@ void DevToolsWindow::AddDevToolsExtensionsToClient() {

for (ExtensionSet::const_iterator extension = extensions->begin();

extension != extensions->end(); ++extension) {

- if (extensions::ManifestURL::GetDevToolsPage(*extension).is_empty())

+ if (extensions::ManifestURL::GetDevToolsPage(extension->get()).is_empty())

continue;

DictionaryValue* extension_info = new DictionaryValue();

- extension_info->Set("startPage", new StringValue(

- extensions::ManifestURL::GetDevToolsPage(*extension).spec()));

+ extension_info->Set(

+ "startPage",

+ new StringValue(

+ extensions::ManifestURL::GetDevToolsPage(extension->get()).spec()));

extension_info->Set("name", new StringValue((*extension)->name()));

bool allow_experimental = (*extension)->HasAPIPermission(

extensions::APIPermission::kExperimental);