chrome/browser/extensions/user_script_listener.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/user_script_listener.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/updater/safe_manifest_parser.cc ('k') | chrome/browser/extensions/webstore_install_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/user_script_listener.cc

diff --git a/chrome/browser/extensions/user_script_listener.cc b/chrome/browser/extensions/user_script_listener.cc

index 3fffc6e70d33c6610f4d6724d1036c0fbb0c8eee..229aa4060399722083e63f734a7da4ed9ad1d5f8 100644

--- a/chrome/browser/extensions/user_script_listener.cc

+++ b/chrome/browser/extensions/user_script_listener.cc

@@ -231,8 +231,8 @@ void UserScriptListener::Observe(int type,

ExtensionService* service = profile->GetExtensionService();

for (ExtensionSet::const_iterator it = service->extensions()->begin();

it != service->extensions()->end(); ++it) {

- if (*it != unloaded_extension)

- CollectURLPatterns(*it, &new_patterns);

+ if (it->get() != unloaded_extension)

+ CollectURLPatterns(it->get(), &new_patterns);

}

BrowserThread::PostTask(BrowserThread::IO, FROM_HERE, base::Bind(

&UserScriptListener::ReplaceURLPatterns, this,

« no previous file with comments | « chrome/browser/extensions/updater/safe_manifest_parser.cc ('k') | chrome/browser/extensions/webstore_install_helper.cc » ('j') | no next file with comments »