chrome/common/cancelable_task_tracker.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/cancelable_task_tracker.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/web_resource/json_asynchronous_unpacker.cc ('k') | chrome/common/cancelable_task_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/cancelable_task_tracker.cc

diff --git a/chrome/common/cancelable_task_tracker.cc b/chrome/common/cancelable_task_tracker.cc

index 4ab86e3250878c0e1d2e16d62fbcca313b38f716..f27d1168862fabfefd96f553ce2411d54b5896a2 100644

--- a/chrome/common/cancelable_task_tracker.cc

+++ b/chrome/common/cancelable_task_tracker.cc

@@ -84,7 +84,7 @@ CancelableTaskTracker::TaskId CancelableTaskTracker::PostTaskAndReply(

DCHECK(thread_checker_.CalledOnValidThread());

// We need a MessageLoop to run reply.

- DCHECK(base::MessageLoopProxy::current());

+ DCHECK(base::MessageLoopProxy::current().get());

// Owned by reply callback below.

CancellationFlag* flag = new CancellationFlag();

@@ -110,7 +110,7 @@ CancelableTaskTracker::TaskId CancelableTaskTracker::PostTaskAndReply(

CancelableTaskTracker::TaskId CancelableTaskTracker::NewTrackedTaskId(

IsCanceledCallback* is_canceled_cb) {

DCHECK(thread_checker_.CalledOnValidThread());

- DCHECK(base::MessageLoopProxy::current());

+ DCHECK(base::MessageLoopProxy::current().get());

TaskId id = next_id_;

next_id_++; // int64 is big enough that we ignore the potential overflow.

« no previous file with comments | « chrome/browser/web_resource/json_asynchronous_unpacker.cc ('k') | chrome/common/cancelable_task_tracker_unittest.cc » ('j') | no next file with comments »