chrome/browser/prefs/pref_service_syncable_builder.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/pref_service_syncable_builder.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/prefs/pref_service_syncable.cc ('k') | chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/prefs/pref_service_syncable_builder.cc

diff --git a/chrome/browser/prefs/pref_service_syncable_builder.cc b/chrome/browser/prefs/pref_service_syncable_builder.cc

index 5dc83c38857d9bd306e32574719376360fd2821d..69a090c559660b9e0aa4fe7a61173cbc7bd44c06 100644

--- a/chrome/browser/prefs/pref_service_syncable_builder.cc

+++ b/chrome/browser/prefs/pref_service_syncable_builder.cc

@@ -48,14 +48,13 @@ PrefServiceSyncable* PrefServiceSyncableBuilder::CreateSyncable(

PrefNotifierImpl* pref_notifier = new PrefNotifierImpl();

PrefServiceSyncable* pref_service = new PrefServiceSyncable(

pref_notifier,

- new PrefValueStore(

- managed_prefs_.get(),

- extension_prefs_.get(),

- command_line_prefs_.get(),

- user_prefs_.get(),

- recommended_prefs_.get(),

- pref_registry->defaults(),

- pref_notifier),

+ new PrefValueStore(managed_prefs_.get(),

+ extension_prefs_.get(),

+ command_line_prefs_.get(),

+ user_prefs_.get(),

+ recommended_prefs_.get(),

+ pref_registry->defaults().get(),

+ pref_notifier),

user_prefs_.get(),

pref_registry,

read_error_callback_,