chrome/browser/sync_file_system/drive_metadata_store.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_metadata_store.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_file_sync_service_unittest.cc ('k') | chrome/browser/sync_file_system/local_file_sync_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_metadata_store.cc

diff --git a/chrome/browser/sync_file_system/drive_metadata_store.cc b/chrome/browser/sync_file_system/drive_metadata_store.cc

index f774f8ecbc4e404ade5f6342a79a6a127574f919..08eaab56664a2cf98503c18a3210a9096442608b 100644

--- a/chrome/browser/sync_file_system/drive_metadata_store.cc

+++ b/chrome/browser/sync_file_system/drive_metadata_store.cc

@@ -646,11 +646,15 @@ void DriveMetadataStore::DidUpdateOrigin(

void DriveMetadataStore::WriteToDB(scoped_ptr<leveldb::WriteBatch> batch,

const SyncStatusCallback& callback) {

base::PostTaskAndReplyWithResult(

- file_task_runner_, FROM_HERE,

- base::Bind(&leveldb::DB::Write, base::Unretained(db_.get()),

- leveldb::WriteOptions(), base::Owned(batch.release())),

+ file_task_runner_.get(),

+ FROM_HERE,

+ base::Bind(&leveldb::DB::Write,

+ base::Unretained(db_.get()),

+ leveldb::WriteOptions(),

+ base::Owned(batch.release())),

base::Bind(&DriveMetadataStore::UpdateDBStatusAndInvokeCallback,

- AsWeakPtr(), callback));

+ AsWeakPtr(),

+ callback));

}

void DriveMetadataStore::UpdateDBStatus(SyncStatusCode status) {