chrome/browser/ui/sync/one_click_signin_helper_unittest.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/pdf/pdf_unsupported_feature.cc ('k') | chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

diff --git a/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc b/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

index bf5b10d3c9ace9c204e8c97ba991be29ae57c43a..3f32a3d2b966592fd6c486a03a326e3a40ddc62d 100644

--- a/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

+++ b/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

@@ -288,11 +288,10 @@ void OneClickSigninHelperTest::AddEmailToOneClickRejectedList(

}

void OneClickSigninHelperTest::AllowSigninCookies(bool enable) {

- CookieSettings* cookie_settings =

- CookieSettings::Factory::GetForProfile(

- Profile::FromBrowserContext(browser_context_.get()));

- cookie_settings->SetDefaultCookieSetting(

- enable ? CONTENT_SETTING_ALLOW : CONTENT_SETTING_BLOCK);

+ CookieSettings* cookie_settings = CookieSettings::Factory::GetForProfile(

+ Profile::FromBrowserContext(browser_context_.get())).get();

+ cookie_settings->SetDefaultCookieSetting(enable ? CONTENT_SETTING_ALLOW

+ : CONTENT_SETTING_BLOCK);

}

void OneClickSigninHelperTest::SetAllowedUsernamePattern(

@@ -359,7 +358,7 @@ TestProfileIOData* OneClickSigninHelperIOTest::CreateTestProfileIOData(

PrefService* pref_service = profile_->GetPrefs();

PrefService* local_state = g_browser_process->local_state();

CookieSettings* cookie_settings =

- CookieSettings::Factory::GetForProfile(profile_);

+ CookieSettings::Factory::GetForProfile(profile_).get();

TestProfileIOData* io_data = new TestProfileIOData(

is_incognito, pref_service, local_state, cookie_settings);

io_data->set_reverse_autologin_pending_email("user@gmail.com");