chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc ('k') | chrome/common/extensions/sync_type_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

index 684f6903b4dc6b4997e991e1d186a524db671b94..f7fe762b7b628f066fc0d3dda782551fc1f789f7 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc

@@ -18,9 +18,9 @@ TEST_F(ValidAppManifestTest, ValidApp) {

AddPattern(&expected_patterns, "http://www.google.com/foobar/*");

EXPECT_EQ(expected_patterns, extension->web_extent());

EXPECT_EQ(extension_misc::LAUNCH_TAB,

- extensions::AppLaunchInfo::GetLaunchContainer(extension));

+ extensions::AppLaunchInfo::GetLaunchContainer(extension.get()));

EXPECT_EQ(GURL("http://www.google.com/mail/"),

- extensions::AppLaunchInfo::GetLaunchWebURL(extension));

+ extensions::AppLaunchInfo::GetLaunchWebURL(extension.get()));

}

TEST_F(ValidAppManifestTest, AllowUnrecognizedPermissions) {