chrome/browser/thumbnails/content_based_thumbnailing_algorithm_unittest.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/thumbnails/content_based_thumbnailing_algorithm_unittest.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/thumbnails/content_based_thumbnailing_algorithm.cc ('k') | chrome/browser/thumbnails/simple_thumbnail_crop.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/thumbnails/content_based_thumbnailing_algorithm_unittest.cc

diff --git a/chrome/browser/thumbnails/content_based_thumbnailing_algorithm_unittest.cc b/chrome/browser/thumbnails/content_based_thumbnailing_algorithm_unittest.cc

index 38b020948b4b2193055adceb559e8ea0efe408c2..05ef7a8735c2ce8af8a50fc95dd327229b7db9fd 100644

--- a/chrome/browser/thumbnails/content_based_thumbnailing_algorithm_unittest.cc

+++ b/chrome/browser/thumbnails/content_based_thumbnailing_algorithm_unittest.cc

@@ -109,7 +109,7 @@ TEST_F(ContentBasedThumbnailingAlgorithmTest, PrepareSourceBitmap) {

source.allocPixels();

source.eraseRGB(50, 150, 200);

SkBitmap result = ContentBasedThumbnailingAlgorithm::PrepareSourceBitmap(

- source, thumbnail_size, context);

+ source, thumbnail_size, context.get());

EXPECT_EQ(CLIP_RESULT_SOURCE_SAME_AS_TARGET, context->clip_result);

EXPECT_GE(result.width(), copy_size.width());

EXPECT_GE(result.height(), copy_size.height());

@@ -122,7 +122,7 @@ TEST_F(ContentBasedThumbnailingAlgorithmTest, PrepareSourceBitmap) {

EXPECT_NEAR(result.height(), source.height(), gfx::scrollbar_size());

result = ContentBasedThumbnailingAlgorithm::PrepareSourceBitmap(

- source, thumbnail_size, context);

+ source, thumbnail_size, context.get());

EXPECT_EQ(CLIP_RESULT_SOURCE_SAME_AS_TARGET, context->clip_result);

EXPECT_GE(result.width(), copy_size.width());

EXPECT_GE(result.height(), copy_size.height());