chrome/browser/browsing_data/browsing_data_remover.cc - Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_remover.cc

Issue 15984016: Call scoped_refptr<T>::get() rather than relying on implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc ('k') | chrome/browser/browsing_data/browsing_data_remover_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_remover.cc

diff --git a/chrome/browser/browsing_data/browsing_data_remover.cc b/chrome/browser/browsing_data/browsing_data_remover.cc

index 3e880f7d9002b804c832651ac5a0d2d70b8108c2..1b74264bfb570c6716858725ca29fcfe47b03226 100644

--- a/chrome/browser/browsing_data/browsing_data_remover.cc

+++ b/chrome/browser/browsing_data/browsing_data_remover.cc

@@ -454,7 +454,7 @@ void BrowsingDataRemover::RemoveImpl(int remove_mask,

if (remove_mask & REMOVE_PASSWORDS) {

content::RecordAction(UserMetricsAction("ClearBrowsingData_Passwords"));

PasswordStore* password_store = PasswordStoreFactory::GetForProfile(

- profile_, Profile::EXPLICIT_ACCESS);

+ profile_, Profile::EXPLICIT_ACCESS).get();

if (password_store)

password_store->RemoveLoginsCreatedBetween(delete_begin_, delete_end_);

@@ -689,7 +689,7 @@ void BrowsingDataRemover::ClearLoggedInPredictor() {

return;

predictors::LoggedInPredictorTable* logged_in_table =

- predictor_db->logged_in_table();

+ predictor_db->logged_in_table().get();

if (!logged_in_table)

return;