Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1845473004: Revert of Move SkGLContext and some GrGLInterface implementations to skgputest module (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
jvanverth1, bsalomon
Base URL:
https://chromium.googlesource.com/skia.git@debugobject
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Move SkGLContext and some GrGLInterface implementations to skgputest module (patchset #13 id:240001 of https://codereview.chromium.org/1815823002/ ) Reason for revert: red bots Original issue's description: > Move SkGLContext and some GrGLInterface implementations to skgputest module > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1815823002 > CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot > > Committed: https://skia.googlesource.com/skia/+/fe3456cb006110d045b26ff3f8681b893a757b58 TBR=jvanverth@google.com,bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/6f70d43719d0583d486a000f66e915c10a6b83a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5432 lines, -6058 lines) Patch
M bench/nanobench.h View 1 chunk +2 lines, -2 lines 0 comments Download
M bench/nanobench.cpp View 3 chunks +8 lines, -11 lines 0 comments Download
M cmake/CMakeLists.txt View 2 chunks +3 lines, -0 lines 0 comments Download
M dm/DM.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M dm/DMGpuSupport.h View 3 chunks +9 lines, -12 lines 0 comments Download
M dm/DMSrcSink.h View 2 chunks +8 lines, -9 lines 0 comments Download
M dm/DMSrcSink.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M gm/image.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/SampleApp.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/flags.gyp View 1 chunk +1 line, -8 lines 0 comments Download
M gyp/gpu.gyp View 3 chunks +56 lines, -0 lines 0 comments Download
M gyp/gpu.gypi View 4 chunks +58 lines, -1 line 0 comments Download
M gyp/gputest.gyp View 1 chunk +11 lines, -68 lines 0 comments Download
M gyp/kilobench.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M gyp/pathops_unittest.gyp View 1 chunk +9 lines, -0 lines 0 comments Download
M gyp/skiaserve.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/visualbench.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +26 lines, -5 lines 0 comments Download
A include/gpu/gl/SkGLContext.h View 1 chunk +145 lines, -0 lines 0 comments Download
A include/gpu/gl/SkNullGLContext.h View 1 chunk +26 lines, -0 lines 0 comments Download
A include/gpu/gl/angle/SkANGLEGLContext.h View 1 chunk +61 lines, -0 lines 0 comments Download
A include/gpu/gl/command_buffer/SkCommandBufferGLContext.h View 1 chunk +63 lines, -0 lines 0 comments Download
M samplecode/SampleApp.cpp View 2 chunks +6 lines, -9 lines 0 comments Download
A src/gpu/GrContextFactory.h View 1 chunk +144 lines, -0 lines 0 comments Download
A src/gpu/GrContextFactory.cpp View 1 chunk +158 lines, -0 lines 0 comments Download
A src/gpu/GrTest.h View 1 chunk +42 lines, -0 lines 0 comments Download
A src/gpu/GrTest.cpp View 1 chunk +419 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLTestInterface.h View 1 chunk +0 lines, -4 lines 0 comments Download
A src/gpu/gl/SkGLContext.cpp View 1 chunk +185 lines, -0 lines 0 comments Download
A src/gpu/gl/SkNullGLContext.cpp View 1 chunk +26 lines, -0 lines 0 comments Download
A src/gpu/gl/angle/GrGLCreateANGLEInterface.cpp View 1 chunk +57 lines, -0 lines 0 comments Download
A src/gpu/gl/angle/SkANGLEGLContext.cpp View 1 chunk +229 lines, -0 lines 0 comments Download
A src/gpu/gl/command_buffer/SkCommandBufferGLContext.cpp View 1 chunk +338 lines, -0 lines 0 comments Download
A src/gpu/gl/debug/GrBufferObj.h View 1 chunk +75 lines, -0 lines 0 comments Download
A src/gpu/gl/debug/GrBufferObj.cpp View 1 chunk +30 lines, -0 lines 0 comments Download
A src/gpu/gl/debug/GrFBBindableObj.h View 1 chunk +87 lines, -0 lines 0 comments Download
A src/gpu/gl/debug/GrFakeRefObj.h View 1 chunk +86 lines, -0 lines 0 comments Download
A src/gpu/gl/debug/GrFrameBufferObj.h View 1 chunk +67 lines, -0 lines 0 comments Download
A src/gpu/gl/debug/GrFrameBufferObj.cpp View 1 chunk +66 lines, -0 lines 0 comments Download
A src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 1 chunk +1236 lines, -0 lines 0 comments Download
A src/gpu/gl/debug/GrProgramObj.h View 1 chunk +42 lines, -0 lines 0 comments Download
A src/gpu/gl/debug/GrProgramObj.cpp View 1 chunk +26 lines, -0 lines 0 comments Download
A src/gpu/gl/debug/GrRenderBufferObj.h View 1 chunk +39 lines, -0 lines 0 comments Download
A src/gpu/gl/debug/GrShaderObj.h View 1 chunk +35 lines, -0 lines 0 comments Download
A src/gpu/gl/debug/GrShaderObj.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
A src/gpu/gl/debug/GrTextureObj.h View 1 chunk +56 lines, -0 lines 0 comments Download
A src/gpu/gl/debug/GrTextureObj.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
A src/gpu/gl/debug/GrTextureUnitObj.h View 1 chunk +44 lines, -0 lines 0 comments Download
A src/gpu/gl/debug/GrTextureUnitObj.cpp View 1 chunk +30 lines, -0 lines 0 comments Download
A src/gpu/gl/debug/GrVertexArrayObj.h View 1 chunk +21 lines, -0 lines 0 comments Download
A src/gpu/gl/debug/SkDebugGLContext.h View 1 chunk +27 lines, -0 lines 0 comments Download
A src/gpu/gl/debug/SkDebugGLContext.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
A src/gpu/gl/egl/SkCreatePlatformGLContext_egl.cpp View 1 chunk +333 lines, -0 lines 0 comments Download
A src/gpu/gl/glx/SkCreatePlatformGLContext_glx.cpp View 1 chunk +343 lines, -0 lines 0 comments Download
A src/gpu/gl/iOS/SkCreatePlatformGLContext_iOS.mm View 1 chunk +106 lines, -0 lines 0 comments Download
A src/gpu/gl/mac/SkCreatePlatformGLContext_mac.cpp View 1 chunk +128 lines, -0 lines 0 comments Download
A src/gpu/gl/mesa/GrGLCreateMesaInterface.cpp View 1 chunk +24 lines, -0 lines 0 comments Download
A src/gpu/gl/mesa/SkMesaGLContext.h View 1 chunk +44 lines, -0 lines 0 comments Download
A src/gpu/gl/mesa/SkMesaGLContext.cpp View 1 chunk +100 lines, -0 lines 0 comments Download
A src/gpu/gl/nacl/SkCreatePlatformGLContext_nacl.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
A src/gpu/gl/win/SkCreatePlatformGLContext_win.cpp View 1 chunk +200 lines, -0 lines 0 comments Download
M src/views/win/SkOSWindow_win.cpp View 2 chunks +1 line, -31 lines 0 comments Download
M tests/EGLImageTest.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GrContextFactoryTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ImageTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/RectangleTextureTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/Test.h View 4 chunks +15 lines, -17 lines 0 comments Download
M tests/TestConfigParsing.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/TestTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/TextureStorageAllocator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/skia_test.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/VisualBench/VisualBench.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/flags/SkCommonFlagsConfig.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/flags/SkCommonFlagsConfig.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
D tools/gpu/GrContextFactory.h View 1 chunk +0 lines, -145 lines 0 comments Download
D tools/gpu/GrContextFactory.cpp View 1 chunk +0 lines, -157 lines 0 comments Download
D tools/gpu/GrTest.h View 1 chunk +0 lines, -42 lines 0 comments Download
D tools/gpu/GrTest.cpp View 1 chunk +0 lines, -419 lines 0 comments Download
D tools/gpu/gl/GLContext.h View 1 chunk +0 lines, -141 lines 0 comments Download
D tools/gpu/gl/GLContext.cpp View 1 chunk +0 lines, -188 lines 0 comments Download
D tools/gpu/gl/angle/GLContext_angle.h View 1 chunk +0 lines, -30 lines 0 comments Download
D tools/gpu/gl/angle/GLContext_angle.cpp View 1 chunk +0 lines, -320 lines 0 comments Download
D tools/gpu/gl/command_buffer/GLContext_command_buffer.h View 1 chunk +0 lines, -68 lines 0 comments Download
D tools/gpu/gl/command_buffer/GLContext_command_buffer.cpp View 1 chunk +0 lines, -345 lines 0 comments Download
D tools/gpu/gl/debug/DebugGLContext.h View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/gpu/gl/debug/DebugGLContext.cpp View 1 chunk +0 lines, -1256 lines 0 comments Download
D tools/gpu/gl/debug/GrBufferObj.h View 1 chunk +0 lines, -76 lines 0 comments Download
D tools/gpu/gl/debug/GrBufferObj.cpp View 1 chunk +0 lines, -31 lines 0 comments Download
D tools/gpu/gl/debug/GrFBBindableObj.h View 1 chunk +0 lines, -88 lines 0 comments Download
D tools/gpu/gl/debug/GrFakeRefObj.h View 1 chunk +0 lines, -86 lines 0 comments Download
D tools/gpu/gl/debug/GrFrameBufferObj.h View 1 chunk +0 lines, -68 lines 0 comments Download
D tools/gpu/gl/debug/GrFrameBufferObj.cpp View 1 chunk +0 lines, -67 lines 0 comments Download
D tools/gpu/gl/debug/GrProgramObj.h View 1 chunk +0 lines, -43 lines 0 comments Download
D tools/gpu/gl/debug/GrProgramObj.cpp View 1 chunk +0 lines, -27 lines 0 comments Download
D tools/gpu/gl/debug/GrRenderBufferObj.h View 1 chunk +0 lines, -40 lines 0 comments Download
D tools/gpu/gl/debug/GrShaderObj.h View 1 chunk +0 lines, -36 lines 0 comments Download
D tools/gpu/gl/debug/GrShaderObj.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
D tools/gpu/gl/debug/GrTextureObj.h View 1 chunk +0 lines, -57 lines 0 comments Download
D tools/gpu/gl/debug/GrTextureObj.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
D tools/gpu/gl/debug/GrTextureUnitObj.h View 1 chunk +0 lines, -44 lines 0 comments Download
D tools/gpu/gl/debug/GrTextureUnitObj.cpp View 1 chunk +0 lines, -31 lines 0 comments Download
D tools/gpu/gl/debug/GrVertexArrayObj.h View 1 chunk +0 lines, -21 lines 0 comments Download
D tools/gpu/gl/egl/CreatePlatformGLContext_egl.cpp View 1 chunk +0 lines, -337 lines 0 comments Download
D tools/gpu/gl/glx/CreatePlatformGLContext_glx.cpp View 1 chunk +0 lines, -346 lines 0 comments Download
D tools/gpu/gl/iOS/CreatePlatformGLContext_iOS.mm View 1 chunk +0 lines, -108 lines 0 comments Download
D tools/gpu/gl/mac/CreatePlatformGLContext_mac.cpp View 1 chunk +0 lines, -128 lines 0 comments Download
D tools/gpu/gl/mesa/GLContext_mesa.h View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/gpu/gl/mesa/GLContext_mesa.cpp View 1 chunk +0 lines, -151 lines 0 comments Download
D tools/gpu/gl/mesa/osmesa_wrapper.h View 1 chunk +0 lines, -16 lines 0 comments Download
D tools/gpu/gl/null/NullGLContext.h View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/gpu/gl/null/NullGLContext.cpp View 1 chunk +0 lines, -630 lines 0 comments Download
D tools/gpu/gl/win/CreatePlatformGLContext_win.cpp View 1 chunk +0 lines, -204 lines 0 comments Download
M tools/kilobench/kilobench.cpp View 8 chunks +9 lines, -12 lines 0 comments Download
M tools/skiaserve/Request.h View 2 chunks +1 line, -3 lines 0 comments Download
M tools/skiaserve/Request.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
robertphillips
Created Revert of Move SkGLContext and some GrGLInterface implementations to skgputest module
4 years, 8 months ago (2016-03-30 16:25:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845473004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845473004/1
4 years, 8 months ago (2016-03-30 16:25:58 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 16:26:29 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6f70d43719d0583d486a000f66e915c10a6b83a2

Powered by Google App Engine
This is Rietveld 408576698