Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1604)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1684063006: Add GrShaderFlags enum (Closed)

Created:
4 years, 10 months ago by Chris Dalton
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add GrShaderFlags enum Replaces GrGLSLUniformHandler::ShaderVisibility with GrShaderFlags. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1684063006 Committed: https://skia.googlesource.com/skia/+/5e58ceea8569f0d90ff7e3daf5de2def50407212

Patch Set 1 #

Patch Set 2 : Bit->Flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -168 lines) Patch
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M include/gpu/GrTypesPriv.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/core/SkColorMatrixFilterRowMajor255.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkLightingShader.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/effects/GrCircleBlurFragmentProcessor.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkAvoidXfermode.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 8 chunks +14 lines, -14 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkPixelXorXfermode.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 1 chunk +6 lines, -6 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 1 5 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 1 1 chunk +5 lines, -6 lines 0 comments Download
M src/gpu/GrFragmentProcessor.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrPathProcessor.cpp View 1 1 chunk +5 lines, -6 lines 0 comments Download
M src/gpu/batches/GrPLSPathRenderer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 1 2 chunks +10 lines, -12 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConstColorProcessor.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 1 5 chunks +14 lines, -14 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrYUVEffect.cpp View 1 4 chunks +6 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLUniformHandler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLUniformHandler.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/gpu/glsl/GrGLSLGeometryProcessor.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/glsl/GrGLSLPrimitiveProcessor.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/glsl/GrGLSLProgramBuilder.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/glsl/GrGLSLProgramBuilder.cpp View 1 4 chunks +5 lines, -6 lines 0 comments Download
M src/gpu/glsl/GrGLSLShaderBuilder.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/glsl/GrGLSLUniformHandler.h View 1 2 chunks +3 lines, -9 lines 0 comments Download
M src/gpu/glsl/GrGLSLXferProcessor.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 1673093002 Patch 100001
Issue 1673093002 Patch 120001
Issue 1673093002 Patch 140001

Messages

Total messages: 11 (5 generated)
Chris Dalton
Just a simple search and replace change. The idea here is so we can reuse ...
4 years, 10 months ago (2016-02-11 19:19:01 UTC) #3
bsalomon
Bit(s)->Flag(s)? Seems more consistent with other bitfield enums.
4 years, 10 months ago (2016-02-11 19:33:51 UTC) #4
Chris Dalton
On 2016/02/11 19:33:51, bsalomon wrote: > Bit(s)->Flag(s)? Seems more consistent with other bitfield enums. Done.
4 years, 10 months ago (2016-02-11 19:47:24 UTC) #5
bsalomon
lgtm
4 years, 10 months ago (2016-02-11 19:55:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684063006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684063006/20001
4 years, 10 months ago (2016-02-11 20:11:59 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 20:49:50 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5e58ceea8569f0d90ff7e3daf5de2def50407212

Powered by Google App Engine
This is Rietveld 408576698