Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

Fix lint errors along the way.

Committed: https://crrev.com/4b36dd31c398092a74425a34d41c34fef49ab94d
Cr-Commit-Position: refs/heads/master@{#302318}

[Lei Zhang, 2014-10-22 18:57:10]

thestig@chromium.org changed reviewers:
+ mek@chromium.org, xiyuan@chromium.org

[Lei Zhang, 2014-10-29 01:04:19]

ping?

[xiyuan, 2014-10-29 01:10:16]

lgtm

[Marijn Kruisselbrink, 2014-10-29 01:36:22]

On 2014/10/29 01:04:19, Lei Zhang wrote:
> ping?
(just changing reviewers doesn't send out any notification, so this ping was the
first I saw of this review request...)

lgtm, with one small question

https://codereview.chromium.org/635573005/diff/80001/chrome/browser/extension...
File chrome/browser/extensions/activity_log/hashed_ad_network_database.h
(right):

https://codereview.chromium.org/635573005/diff/80001/chrome/browser/extension...
chrome/browser/extensions/activity_log/hashed_ad_network_database.h:19: void
set_entries_for_testing(const char** entries, int num_entries) {
should this also be const char* const like entries_?

[Lei Zhang, 2014-10-31 19:39:27]

https://codereview.chromium.org/635573005/diff/80001/chrome/browser/extension...
File chrome/browser/extensions/activity_log/hashed_ad_network_database.h
(right):

https://codereview.chromium.org/635573005/diff/80001/chrome/browser/extension...
chrome/browser/extensions/activity_log/hashed_ad_network_database.h:19: void
set_entries_for_testing(const char** entries, int num_entries) {
On 2014/10/29 01:36:21, Marijn Kruisselbrink wrote:
> should this also be const char* const like entries_?

Done.

[Lei Zhang, 2014-10-31 19:39:34]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-10-31 19:40:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/635573005/100001

[Lei Zhang, 2014-10-31 20:00:45]

On 2014/10/29 01:36:22, Marijn Kruisselbrink wrote:
> On 2014/10/29 01:04:19, Lei Zhang wrote:
> > ping?
> (just changing reviewers doesn't send out any notification, so this ping was
the
> first I saw of this review request...)

And yes, this was a failure on my part. I know you guys are usually more
responsive.

[commit-bot: I haz the power, 2014-10-31 20:30:37]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-10-31 20:31:18]

Patchset 6 (id:??) landed as
https://crrev.com/4b36dd31c398092a74425a34d41c34fef49ab94d
Cr-Commit-Position: refs/heads/master@{#302318}