chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc - Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, nit Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_content/request_content_script_apitest.cc ('k') | chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc

index 004ff2164782e0726b2d11898bebf6dec9ca9e78..0c6bea8993ebe28bb26d7c3216815140a7912b87 100644

--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc

+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc

@@ -558,7 +558,7 @@ TEST(WebRequestActionTest, GetName) {

" \"lowerPriorityThan\": 123,"

" \"hasTag\": \"some_tag\""

"}]";

- const char* kExpectedNames[] = {

+ const char* const kExpectedNames[] = {

"declarativeWebRequest.RedirectRequest",

"declarativeWebRequest.RedirectByRegEx",

"declarativeWebRequest.SetRequestHeader",