chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc - Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, nit Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/memory/oom_priority_manager.cc ('k') | chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

diff --git a/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc b/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

index e7495946c178898762eb262877bf27d464d41830..b34cf1ee7c1170726bd7f79d5a03c90d46c75115 100644

--- a/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

+++ b/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

@@ -31,11 +31,11 @@ namespace chromeos {

namespace {

-const char* kNotificationId =

+const char* const kNotificationId =

NetworkPortalNotificationController::kNotificationId;

-const char* kNotificationMetric =

+const char* const kNotificationMetric =

NetworkPortalNotificationController::kNotificationMetric;

-const char* kUserActionMetric =

+const char* const kUserActionMetric =

NetworkPortalNotificationController::kUserActionMetric;

const char kTestUser[] = "test-user@gmail.com";